Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to procedural reflection map calculation. #6467

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

abwood
Copy link
Contributor

@abwood abwood commented Apr 19, 2018

Clamp horizonDotNadir calculation to effectively push any subsurface position up to the surface. Without this, geometry positioned close to the center of the Earth will turn white.

Note this does not target master. This change builds on @emackey's current pbr-lighting branch.

…position up to the surface. Without this, geometry positioned close to the center of the Earth will turn white.
@cesium-concierge
Copy link

Please sign the CLA before we review this PR.

Welcome to the Cesium community @abwood!

Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

⚠️ I noticed that a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version. Once you do, please confirm by commenting on this pull request.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Apr 19, 2018

Thanks @abwood! I'll let @emackey review, but you'll need to submit the same change to gltf-pipeline on the 2.0-cesium branch

@emackey
Copy link
Contributor

emackey commented Apr 19, 2018

Thanks @hpinkos, I'll take care of copying to gltf-pipline.

Looks like we need to add @abwood to the corporate CLA list for Concierge.

@emackey emackey merged commit 15a6b1c into CesiumGS:pbr-lighting Apr 19, 2018
@emackey
Copy link
Contributor

emackey commented Apr 19, 2018

This is for #6430

@hpinkos
Copy link
Contributor

hpinkos commented Apr 19, 2018

@emackey yep, I added Alex to the CLA list

emackey added a commit to emackey/gltf-pipeline that referenced this pull request Apr 19, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Minor fix to procedural reflection map calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants