Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified the need to call scene.render in between picks with pickTranslucentDepth #6496

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

hanbollar
Copy link

Fixes #6151

@cesium-concierge
Copy link

Signed CLA is on file.

@hanbollar, thanks for the pull request! Maintainers, we have a signed CLA from @hanbollar, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hanbollar
Copy link
Author

@ggetz lmk if this is the update you're looking for

* return;
* }
* viewer.scene.render();
* console.log(viewer.scene.pickPosition(movement.position));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanbollar change this to something like var worldPosition = viewer.scene.pickPosition(movement.position));

@hanbollar hanbollar force-pushed the pickTranslucentDepth-doc-change branch from 956d402 to 6302356 Compare April 25, 2018 17:42
@hanbollar
Copy link
Author

@hpinkos updated with the change

@hpinkos
Copy link
Contributor

hpinkos commented Apr 25, 2018

Great, thanks!

@hpinkos hpinkos merged commit 46b85ac into CesiumGS:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants