Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Dynamic Point Clouds #6721

Merged
merged 41 commits into from
Jul 11, 2018
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
2dab089
Added PointCloud class
lilleyse May 29, 2018
61065d8
Added PointCloudStream class
lilleyse May 30, 2018
96cd741
Start of prefetching code
lilleyse May 31, 2018
a618a7e
Batch id uint32 fix
lilleyse Jun 7, 2018
4704934
Rename PointCloudStream to TimeDynamicPointCloud
lilleyse Jun 13, 2018
ab37223
Updates in preparation for auto-skipping frames
lilleyse Jun 13, 2018
d2df499
Merge branch 'point-clouds-draco' into point-cloud-stream-new
lilleyse Jun 18, 2018
cd219a8
More picking updates
lilleyse Jun 18, 2018
45382e7
Documentation and cleanup
lilleyse Jun 19, 2018
0e44cf8
Added Sandcastle demo
lilleyse Jun 19, 2018
1c62498
Frame skipping added
lilleyse Jun 21, 2018
23fb235
Minor wording and organization changes
lilleyse Jun 22, 2018
45f20bc
Merge branch 'point-clouds-draco' into point-cloud-stream-new
lilleyse Jun 22, 2018
59e169a
Update Sandcastle demo
lilleyse Jun 22, 2018
f505207
Move uniform map creation so it's easier to merge in mutables
lilleyse Jun 22, 2018
bd67113
Avoid skipping requested frames
lilleyse Jun 26, 2018
f30e694
Get the next interval more aggressively
lilleyse Jun 26, 2018
a4f2d21
Calculate average load time from the last N frames
lilleyse Jun 26, 2018
c4a0620
Merge branch 'point-clouds-draco' into point-cloud-stream-new
lilleyse Jun 26, 2018
178003f
Documentation updates
lilleyse Jun 26, 2018
b166766
Fix edge case where first frame is not loaded sequentially and an ave…
lilleyse Jun 27, 2018
3455dc3
Initial work for computing bounding sphere
lilleyse Jun 27, 2018
70cac08
Add PERFORMANCE_IDEA for sharing GPU resources
lilleyse Jun 27, 2018
9d6552c
Make quantizedVolumeScale consistent across Draco and 16-bit quantize…
lilleyse Jun 27, 2018
e1cf350
Make useNormals more like useColors and backFaceCulling
lilleyse Jun 27, 2018
52632b3
Updated demo
lilleyse Jun 27, 2018
8f6a975
Updated CHANGES.md
lilleyse Jun 27, 2018
ed8624c
Pass in same point cloud state to prepareFrame as renderFrame to mini…
lilleyse Jun 28, 2018
eacc367
Added tests
lilleyse Jun 28, 2018
3739e84
Rename tilesets folder to Cesium3DTiles
lilleyse Jul 2, 2018
eb1ceeb
Merge branch 'point-clouds-draco' into point-cloud-stream-new
lilleyse Jul 2, 2018
04a8797
Fix EDL test for webgl-stub
lilleyse Jul 3, 2018
a9d2be7
Rename pointCloudShading to shading
lilleyse Jul 3, 2018
e1fddc0
More description for frameFailed event
lilleyse Jul 3, 2018
f531406
Added viewer.zoomTo(timeDynamicPointCloud)
lilleyse Jul 3, 2018
dd7a59c
Merge branch 'master' into point-cloud-stream-new
lilleyse Jul 9, 2018
adf8f4e
Comment about quantized range and scale
lilleyse Jul 5, 2018
cb9ee74
frame changed event, ready promise, and other updates
lilleyse Jul 10, 2018
a7baeff
Updates
lilleyse Jul 10, 2018
b2b94f5
Fix test
lilleyse Jul 11, 2018
3294f35
Merge branch 'master' into point-cloud-stream-new
lilleyse Jul 11, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Source/Scene/TimeDynamicPointCloud.js
Original file line number Diff line number Diff line change
@@ -233,7 +233,8 @@ define([

function getAverageLoadTime(that) {
if (that._runningLength === 0) {
return undefined;
// Before any frames have loaded make a best guess about the average load time
return 0.05;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this based on? Can we grab any properties from the browser or system to make a more specific guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically arbitrary - tuned roughly to a 300kb Draco tile. We would need to know tile size before it's downloaded and network speed to make a proper guess. I don't think it matters too much since the average will get corrected once tiles start to load.

}
return that._runningAverage;
}
@@ -261,10 +262,6 @@ define([
}

var averageLoadTime = getAverageLoadTime(that);
if (!defined(averageLoadTime)) {
return undefined;
}

var time = JulianDate.addSeconds(clock.currentTime, averageLoadTime * multiplier, scratchDate);
var index = intervals.indexOf(time);