Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holes and stRotation to coplanar polygon #6787

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Add holes and stRotation to coplanar polygon #6787

merged 1 commit into from
Jul 11, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 10, 2018

As much as I didn't want to do this, as soon as I looked at wiring up CoplanarPolygonGeometry to the entity layer it was very obvious that I should make CoplanaryPolygonGeometry supported features mirror what we do in PolygonGeometry.

  • Added support for holes using a PolygonHierarchy
  • Added stRotation option (You were right @ggetz =P)

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor Author

hpinkos commented Jul 10, 2018

@bagnell can you review please?

@hpinkos hpinkos mentioned this pull request Jul 10, 2018
2 tasks
@bagnell
Copy link
Contributor

bagnell commented Jul 11, 2018

👍

@bagnell bagnell merged commit 5e119d3 into master Jul 11, 2018
@bagnell bagnell deleted the polygon-api branch July 11, 2018 20:01
@Alegriabaile
Copy link

Hi, hpinkos. Thanks for provide the CoplanarPolygonGeometry && CoplanarPolygonOutlineGeometry interface, it really helps!

@Alegriabaile
Copy link

If anyone wants a demo of CoplanarPolygonOutlineGeometry, here is how I found:
I tried to find a demo of CoplanarPolygonOutlineGeometry with google but failed. I tried create the outline like PolygonOutlineGeometry/CoplanarPolygonGeometry but still failed. By the way, I found the description of the constructor of CoplanarPolygonOutlineGeometry is outdated.
At last, I found the demo【Sandcastle/gallery/development/Coplanar Polygon Outline.html】 and applied CoplanarPolygonOutlineGeometry to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants