Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7018
OIT was checking if log depth was enabled by checking if the derived command exists. Now it checks if
frameState.useLogDepth
is true which is more reliable.This worked before because the log depth command was set to undefined if log depth was off (
fb63af
). This was changed to make it more efficient to call the pick from ray functions which if called often will constantly change the log depth state, where it's better to keep the log depth commands around.@bagnell probably best for you to review since it's a follow up to #6957