Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIT and log depth slowness fix #7019

Merged
merged 2 commits into from
Sep 11, 2018
Merged

OIT and log depth slowness fix #7019

merged 2 commits into from
Sep 11, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Sep 7, 2018

Fixes #7018

OIT was checking if log depth was enabled by checking if the derived command exists. Now it checks if frameState.useLogDepth is true which is more reliable.

This worked before because the log depth command was set to undefined if log depth was off (fb63af). This was changed to make it more efficient to call the pick from ray functions which if called often will constantly change the log depth state, where it's better to keep the log depth commands around.

@bagnell probably best for you to review since it's a follow up to #6957

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@bagnell
Copy link
Contributor

bagnell commented Sep 10, 2018

I see ~40 test failures.

@lilleyse
Copy link
Contributor Author

@bagnell thanks for catching that, I should have ran the tests locally.

The fix was to not look for derived log depth commands on the inverse classification commands. The classification related sandcastle demos look good now.

@bagnell
Copy link
Contributor

bagnell commented Sep 11, 2018

The fix was to not look for derived log depth commands on the inverse classification commands. The classification related sandcastle demos look good now.

That was probably a copy-paste error since they're a sort of post-process.

Looks good 👍

@bagnell bagnell merged commit db8a9f1 into master Sep 11, 2018
@bagnell bagnell deleted the oit-log-depth-fix branch September 11, 2018 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants