Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standalone Sandcastle mode #7097

Closed
wants to merge 1 commit into from
Closed

Create standalone Sandcastle mode #7097

wants to merge 1 commit into from

Conversation

OmarShehata
Copy link
Contributor

Right now, if you click "Open in New Window" in Sandcastle it will requests from ion will fail, and you'll just see a blue sphere.

This PR creates a page to render any Sandcastle example as a standalone page that opens when you click "Open in a New Window". So any Sandcastle link that looks like:

https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=ZYw7C8Iw...

Will now also be accessible at:

https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/Standalone/#c=ZYw7C8Iw...

The other motivation to do this is to be able to show Sandcastle examples on mobile. You can easily share the second link now (or just click the open in new window button).

The other issue is, at least on my iPhone 5s Safari, the current open in new window blob URL just loads the HTML as text and doesn't actually render.

If there's a better way to get Sandcastle to look nice on mobile I'm happy to hear it.

I also added a few dependencies to get this to work, but I wonder if these should be added to devDependencies instead?

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Sorry, something went wrong.

@mramato
Copy link
Contributor

mramato commented Oct 1, 2018

Thanks @OmarShehata. Unfortunately this PR will have to take a completely different approach in order for us to be able to merge it. Sandcastle is intentionally a client-side only app that will run in any statically hosted web-server, so we can't rely on Node.js specific routes or back-end code.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 23, 2018

Closing this since this is not the approach we want to take here.

@hpinkos hpinkos closed this Oct 23, 2018
@emackey
Copy link
Contributor

emackey commented Oct 25, 2018

@OmarShehata Take a look at #5858, I think it's relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants