Create standalone Sandcastle mode #7097
Closed
+81
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you click "Open in New Window" in Sandcastle it will requests from ion will fail, and you'll just see a blue sphere.
This PR creates a page to render any Sandcastle example as a standalone page that opens when you click "Open in a New Window". So any Sandcastle link that looks like:
Will now also be accessible at:
The other motivation to do this is to be able to show Sandcastle examples on mobile. You can easily share the second link now (or just click the open in new window button).
The other issue is, at least on my iPhone 5s Safari, the current open in new window blob URL just loads the HTML as text and doesn't actually render.
If there's a better way to get Sandcastle to look nice on mobile I'm happy to hear it.
I also added a few dependencies to get this to work, but I wonder if these should be added to
devDependencies
instead?