-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix artifacts in BIM demo #7181
Conversation
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Please make this a check box that defaults to |
Where is the code doing the patching? I don't see it at glance. |
Not too bad but just depends on the view; agree to stay with just highlight for now. |
Not ideal but OK for now. |
Update CHANGES.md mainly to just build awareness of BIM in Cesium and per-feature selection. |
Thanks for upgrading this, bump when ready. |
@pjcozzi Ready |
ah, lol |
@lilleyse please submit a separate cleanup issue for this model so we can remove the workarounds. The workarounds are fine for demoing BIM / interiors, but not a useful code example. |
I believe that is a log-depth problem rather than the near plane being too far - #6573 (comment) |
Thanks!!! |
Fixes #5722
Updates the tileset used in the BIM demo. Live Demo.
Also adds hover-over picking to the demo. Because we don't have global batch ids there is a bit of boilerplate in there to get it to work.
I wanted to add silhouetting but I felt like there were too many artifacts. Example
To do: