Fix crash when removing a post-process stage. #7213
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @bagnell!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
reviewed
Oct 31, 2018
| @@ -294,6 +294,9 @@ define([ | |||
| var stages = arraySlice(this._stages); | |||
| while (stages.length > 0) { | |||
| var stage = stages.pop(); | |||
| if (!defined(stage)) { | |||
There was a problem hiding this comment.
Is it expected that a stage in this list would be undefined? Just want to make sure this isn't a deeper issue.
There was a problem hiding this comment.
Yes. See this line in remove: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/PostProcessStageCollection.js#L402
They are set to undefined and removed on the next update.
|
This fixes the issue. Thanks @bagnell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7210.