Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint errors in CI #7535

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Fix eslint errors in CI #7535

merged 1 commit into from
Feb 1, 2019

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Feb 1, 2019

The latest eslint version has breaking changes. Resolves eslint errors in CI by setting eslint to exactly version 5.12.1.

@ggetz ggetz requested a review from mramato February 1, 2019 20:39
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@ggetz ggetz changed the title Fix eslint error in CI Fix eslint errors in CI Feb 1, 2019
@mramato
Copy link
Contributor

mramato commented Feb 1, 2019

Can you write up an issue to unpin this once https://github.com/BenoitZugmeyer/eslint-plugin-html/issues/ is addressed?

@ggetz
Copy link
Contributor Author

ggetz commented Feb 1, 2019

Opened #7536

@mramato
Copy link
Contributor

mramato commented Feb 1, 2019

Thanks, I confirmed that the eslint stage passed in CI, so in the interest of time I'm merging this which should fix master.

@mramato mramato merged commit 5d00c8e into master Feb 1, 2019
@mramato mramato deleted the eslint-version branch February 1, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants