Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading models with some but not all Draco compression #7537

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Feb 1, 2019

Fix models crashing where some primitive attributes were draco compressed and others were not.
Fixes #7383.

There was an attempt to add de-quantization to the shader, but returned undefined. Any attempt to use the shader string later would cause a crash.

@cesium-concierge
Copy link

Thanks for the pull request @bagnell!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

lilleyse commented Feb 1, 2019

Thanks @bagnell.

@lilleyse lilleyse merged commit d8b18dc into master Feb 1, 2019
@lilleyse lilleyse deleted the draco-loading branch February 1, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants