Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build-watch task #7724

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

jasonbeverage
Copy link
Contributor

This fixes the build-watch task with the upgraded gulp. Without this change you get:
Error: watching Specs//*.js,!Specs/SpecList.js,Source/Shaders//*.glsl: watch task has to be a function (optionally generated by using gulp.parallel or gulp.series)

Verified

This commit was signed with the committer’s verified signature.
gjermundgaraba Gjermund Garaba
@cesium-concierge
Copy link

Thanks for the pull request @jasonbeverage!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Sorry, something went wrong.

@mramato
Copy link
Contributor

mramato commented May 8, 2019

Thanks @jasonbeverage

@mramato mramato merged commit 6dee149 into CesiumGS:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants