Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent colorToAlpha from carrying over from one imagery layer to its replacement #7736

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

likangning93
Copy link
Contributor

#7727 had a funny bug where switching an imagery layer with color-to-alpha out and not setting color-to-alpha on the new layer would retain the color-to-alpha settings from the previous layer.

This PR always sets the value in the color-to-alpha uniform to a value that won't cause any change, regardless of whether it's used or not.

@cesium-concierge
Copy link

Thanks for the pull request @likangning93!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@likangning93
Copy link
Contributor Author

Bug introduced in this release, so no CHANGES update.

@likangning93
Copy link
Contributor Author

@bagnell there might be one more thing, will bump when ready.

@likangning93
Copy link
Contributor Author

@bagnell ready!

@bagnell
Copy link
Contributor

bagnell commented Apr 10, 2019

Thanks for catching these.

@bagnell bagnell merged commit 4b92d28 into master Apr 10, 2019
@bagnell bagnell deleted the colorToAlpha branch April 10, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants