Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.57 deprecation warnings #7799

Merged
merged 2 commits into from
May 1, 2019
Merged

Remove 1.57 deprecation warnings #7799

merged 2 commits into from
May 1, 2019

Conversation

OmarShehata
Copy link
Contributor

This removes the deprecation warnings for fetchImage #7630 and followSurface #7504.

@tfili

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@tfili
Copy link
Contributor

tfili commented May 1, 2019

@OmarShehata You have 2 failing tests.

Also, thanks for getting to these.

@OmarShehata
Copy link
Contributor Author

@tfili I ended up having to not just remove followSurface from the public API, but also all uses internally, because otherwise, the constructor no longer accepted the option, but you could then set it on a polyline directly and it would work.

So I removed it, and updated the tests. Two tests were completely removed:

  • PolylineGeometrySpec.js / constructor converts followSurface to arcType, because it was testing whether the constructor correctly converts this deprecated option.
  • PolylineGeometryUpdaterSpec.js / followSurface true with undefined globe does not call generateCartesianArc, because it was just a duplicate of the test below it for followSurface instead of arcType.

I did NOT remove anything in the CZML adapting the option because that's intentionally there for backwards compatibility. The polyline Sandcastles seem to work correctly.

@tfili tfili merged commit 90695fd into CesiumGS:master May 1, 2019
@OmarShehata OmarShehata deleted the deprecation-warnings branch May 1, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants