New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test code cleanup. #7807

Merged

mramato merged 1 commit into master from testCleanup

May 3, 2019

Contributor

shunter commented May 1, 2019

Use toBeInstanceOf and other matchers instead of matching a boolean, for better failure messages.


          Test code cleanup. Use toBeInstanceOf and other matchers instead of m…

ea90bf9

…atching a boolean, for better failure messages.

cesium-concierge commented May 1, 2019

Thanks for the pull request @shunter!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

shunter added the cleanup label

mramato merged commit 284b70b into master

mramato deleted the testCleanup branch

May 3, 2019 15:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels