Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check childTileMask if provider doesn't know tile availability. #7851

Merged
merged 2 commits into from
May 21, 2019

Conversation

kring
Copy link
Member

@kring kring commented May 18, 2019

When the terrain tileset doesn't include a layer.json file, the only way to determine tile availability is to look at the parent tile's childTileMask. But I neglected to do that in my terrain refactoring.

Note that the absence of a layer.json means we have no choice to be refine down through the tile pyramid one level at a time, so adding a layer.json is highly recommended for performance reasons. But at least with this PR we won't request a bunch of non-existent tiles.

Fixes #7847

@cesium-concierge
Copy link

Thanks for the pull request @kring!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks a lot @kring ! I've been trying to debug this issue on the forum for a while.

@tfili I can confirm this fixes the issue shown in the Sandcastle in the linked issue. Code looks good. Do you want to do a final review and merge?

@tfili tfili merged commit a9c31c7 into master May 21, 2019
@tfili tfili deleted the child-tile-mask branch May 21, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants