Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require individual source classes in sandcastle app #8158

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Sep 13, 2019

No description provided.

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor Author

hpinkos commented Sep 16, 2019

@OmarShehata please review

@OmarShehata
Copy link
Contributor

It would have been helpful to link to #7523 for context in the PR description.

While I think the way Sandcastle is structured now is still incredibly confusing (the built version relies on the require'd Cesium failing to load, and loading it from window.Cesium, which comes from somewhere else?) this looks like an improvement if the built Sandcastle doesn't break when it can't access Source/.

@OmarShehata OmarShehata merged commit a92cf4c into master Sep 17, 2019
@OmarShehata OmarShehata deleted the no-source-in-sandcastle branch September 17, 2019 13:10
@hpinkos
Copy link
Contributor Author

hpinkos commented Sep 17, 2019

Oh, i didn't realize we had that issue written up. thanks @OmarShehata

@mramato
Copy link
Contributor

mramato commented Sep 17, 2019

@OmarShehata if you ever really wanted an awesome side project, rewriting Sandcastle is probably number 2 on the list of longstanding giant undertakings (ES6 is number 1).

I'm actually a little concerned about how easily we'll be able to update Sandcastle for ES6 Cesium, so the issues are slightly related. Might be a good discussion to have at our code sprint, even if we can't take on the challenge this time around, preparing a roadmap issue with a full breakdown of doing it would be a big help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants