Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sortRequires, remove many unused modules #8167

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Run sortRequires, remove many unused modules #8167

merged 1 commit into from
Sep 16, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Sep 16, 2019

This is just some minor clean-up ahead of some ES6 work I'm going to be doing. One benefit of moving to ES6 is that unused modules will be caught by ESLint all of the time.

In fact, this is probably the last time we'll run sortRequires since it's not generally useful in non-ADM configurations.

This is just some minor clean-up ahead of some ES6 work I'm going to be
doing. One benefit of moving to ES6 is that unused modules will be caught
by ESLint all of the time.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor Author

mramato commented Sep 16, 2019

I'll just instamerge this after CI passes.

@mramato mramato merged commit 013e0ae into master Sep 16, 2019
@mramato mramato deleted the sort-requires branch September 16, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants