Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollup plugin to strip pragmas #8186

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

shehzan10
Copy link
Member

Add a rollup plugin that removes pragmas from files.

The plugin takes include/exclude files as input along with an array of pragmas to remove, then removes them.

@mramato

@cesium-concierge
Copy link

Thanks for the pull request @shehzan10!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Sorry, something went wrong.

@mramato
Copy link
Contributor

mramato commented Sep 19, 2019

Thanks @shehzan10. Sorry for all the conflicts but I'm trying to clean up the git history for the ES6 work. Can you reset this branch against es6-modules and retarget the PR? Thanks!

@shehzan10 shehzan10 force-pushed the es6-playground-strip-pragmas branch from 8f15a17 to 6c645f0 Compare September 20, 2019 14:01
@shehzan10 shehzan10 force-pushed the es6-playground-strip-pragmas branch from 6c645f0 to 7576e7c Compare September 20, 2019 14:05
@shehzan10 shehzan10 changed the base branch from es6-playground to es6-viewer September 20, 2019 14:05
@shehzan10
Copy link
Member Author

@mramato updated to target es6-viewer and rebased of it.

@mramato
Copy link
Contributor

mramato commented Sep 20, 2019

Thanks. I was thinking we may want to put this in its own subdirectory so that we can release it as it's own package later on, but that can happen when actually needed by our users (or ourselves for other repositories)

@mramato mramato merged commit b7cc90f into CesiumGS:es6-viewer Sep 20, 2019
@shehzan10 shehzan10 deleted the es6-playground-strip-pragmas branch September 20, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants