Get ES6 unit tests and coverage running #8199
Merged
+82
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For MVP ES6 support, we're going to run in ES6-aware browsers only, so no IE. Chrome and Firefox works great (and I suspect Safari as well). We can definitely look into transpiling back to ES5 in a future update, but I'm more worried about overall ES6 support right now. This loses the ability to run tests against the release build, but I plan on hopefully putting that back in before everything merges up to master. There are a couple of test failures, but those will get looked into separately than the actual test running mechanism itself. 1. Runs via node/CI and in the browser (which I honestly didn't think we could keep going). 2. Switch to `karma-coverage-istanbul-instrumenter` for instrumentation since we need it for native es6 support 3. Generate an ES6 version of SpecList.js and update spec-main.js to use it. 4. Change to karma-conf.js to treat specs as ES6 5. Fix up some paths/specs to actually work.
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
|
|
Like you said, some tests are failing, but coverage and running tests in the browser appears to be working well. I don't have any feedback |
|
Talking with @hpinkos offline, to move faster we're going to switch to a coarse 2 PR approach. Basically #8192 will stay open until the end (as planned) but everything else will go into #8193 right away. This way you don't have the 16k lines of cruft getting in the way of the review, but reviewers can just do on PR review at the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MVP ES6 support, we're going to run in ES6-aware browsers only, so no IE. Chrome and Firefox works great (and I suspect Safari as well).
We can definitely look into transpiling back to ES5 in a future update, but I'm more worried about overall ES6 support right now.
This loses the ability to run tests against the release build, but I plan on hopefully putting that back in before everything merges up to master.
There are a couple of test failures, but those will get looked into separately than the actual test running mechanism itself.
Runs via node/CI and in the browser (which I honestly didn't think we could keep going).
Switch to
karma-coverage-istanbul-instrumenterfor instrumentation since we need it for native es6 supportGenerate an ES6 version of SpecList.js and update spec-main.js to use it.
Change to karma-conf.js to treat specs as ES6
Fix up some paths/specs to actually work.
Just run the tests as normal to make sure stuff works.
This is targeted to
es6-viewerbut I'll retarget if that gets merged first.CC @hpinkos