Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pickPosition accuracy when depthTestAgainstTerrain is false #8207

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'fix-multifrustum' into fix-pick-position
lilleyse committed Sep 24, 2019
commit a04d05c78e5710cdb8ce929933aa083adfd8a272
2 changes: 1 addition & 1 deletion Source/Scene/Scene.js
Original file line number Diff line number Diff line change
@@ -2485,7 +2485,7 @@ define([
// PERFORMANCE_IDEA: Use MRT to avoid the extra copy.
var depthStencilTexture = renderTranslucentDepthForPick ? passState.framebuffer.depthStencilTexture : globeDepth.framebuffer.depthStencilTexture;
var colorTexture = passState.framebuffer.getColorTexture(0);
var pickDepth = getPickDepth(scene, index);
var pickDepth = scene._picking.getPickDepth(scene, index);
pickDepth.update(context, depthStencilTexture, colorTexture);
pickDepth.executeCopyDepth(context, passState, usePrimitiveFramebuffer, picking);
}
You are viewing a condensed version of this merge commit. You can view the full changes here.