Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to run specs against built versions of cesium. #8223

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Sep 25, 2019

Since the specs use ES6 modules and built Cesium is an ES5 UMD, I added a build-specs build step which generates an combined ES5 version of the specs which rely on Cesium as a global variable. We then inject these files into jasmine instead of the standard specs and everything works exactly as it did before.

It was deceptively simple once I had my eureka moment.

Need to build tests first via new `build-specs` gulp task.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • ❔ Changes to third party files were made.
    • Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato mramato merged commit da62eb2 into es6-viewer Sep 25, 2019
@mramato mramato deleted the built-specs branch September 25, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants