Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBL CHANGES.md fix #8427

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Add IBL CHANGES.md fix #8427

merged 1 commit into from
Dec 2, 2019

Conversation

OmarShehata
Copy link
Contributor

I forgot to add a CHANGES.md entry for my IBL error-reporting fix in #8303.

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@ggetz
Copy link
Contributor

ggetz commented Dec 2, 2019

Thanks @OmarShehata !

@ggetz ggetz merged commit e5548f7 into master Dec 2, 2019
@ggetz ggetz deleted the changes branch December 2, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants