Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8105 - Explicitly enable EXT_float_blend to silence WebGL warnings #8534

Merged
merged 3 commits into from
Jan 13, 2020
Merged

8105 - Explicitly enable EXT_float_blend to silence WebGL warnings #8534

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18119d2
8105 - Explicitly enable EXT_float_blend to silence WebGL warnings
Jan 13, 2020
60599c2
8105 - Update CHANGES.md with WebGL warning notice
Jan 13, 2020
9cc1120
Update CHANGES.md
Samulus Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Change Log

##### Fixes :wrench:
* Fixed a bug where the camera could go underground during mouse navigation. [#8504](https://github.com/AnalyticalGraphicsInc/cesium/pull/8504)
* Fixed WebGL warning message about `EXT_float_blend` being implicitly enabled

### 1.65.0 - 2020-01-06

Expand Down
14 changes: 14 additions & 0 deletions Source/Renderer/Context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ import VertexArray from './VertexArray.js';
this._textureHalfFloatLinear = !!getExtension(gl, ['OES_texture_half_float_linear']);

this._colorBufferFloat = !!getExtension(gl, ['EXT_color_buffer_float', 'WEBGL_color_buffer_float']);
this._floatBlend = !!getExtension(gl, ['EXT_float_blend']);
this._colorBufferHalfFloat = !!getExtension(gl, ['EXT_color_buffer_half_float']);

this._s3tc = !!getExtension(gl, ['WEBGL_compressed_texture_s3tc', 'MOZ_WEBGL_compressed_texture_s3tc', 'WEBKIT_WEBGL_compressed_texture_s3tc']);
Expand Down Expand Up @@ -500,6 +501,19 @@ import VertexArray from './VertexArray.js';
}
},

/**
* <code>true</code> if the EXT_float_blend extension is supported. This
* extension enables blending with 32-bit float values.
* @memberof Context.prototype
* @type {Boolean}
* @see {@link https://www.khronos.org/registry/webgl/extensions/EXT_float_blend/}
*/
floatBlend : {
get : function() {
return this._floatBlend;
}
},

/**
* <code>true</code> if the EXT_blend_minmax extension is supported. This
* extension extends blending capabilities by adding two new blend equations:
Expand Down