Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace defineProperties with native Object.defineProperties #8633

Merged
merged 4 commits into from
Feb 26, 2020

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Feb 26, 2020

Related to #8515

Object.defineProperties is supported since IE 9 (ES5)

I've neither updated CHANGES.md nor deprecated the defineProperties polyfill because it was private.

eslint is now correctly checking if the getters are returning a value so I had to add few eslint-disable-line (211148e)

@cesium-concierge
Copy link

Thanks for the pull request @fredj!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Sorry, something went wrong.

@mramato
Copy link
Contributor

mramato commented Feb 26, 2020

@shunter any arguments against here? I know the original reason for this polyfill was so CesiumJS could fail gracefully on IE < 11, but at this point those browsers should no longer be a concern.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 26, 2020

@mramato @shunter threw his two cents in in this PR #8526 (comment)

I think we can probably merge both if you agree

@mramato
Copy link
Contributor

mramato commented Feb 26, 2020

Thanks @hpinkos

And thanks @fredj!

@nmschulte
Copy link
Contributor

I've neither updated CHANGES.md nor deprecated the defineProperties polyfill because it was private.

Ouch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants