Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing references from ManagedArray and Heap #8889

Merged
merged 3 commits into from
Jun 28, 2020
Merged

Remove trailing references from ManagedArray and Heap #8889

merged 3 commits into from
Jun 28, 2020

Conversation

lilleyse
Copy link
Contributor

This is a companion PR to #8883 that removes trailing references when elements are removed from ManagedArray and Heap.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse mentioned this pull request May 31, 2020
Merged
@lilleyse lilleyse requested a review from IanLilleyT June 3, 2020 16:55
IanLilleyT
IanLilleyT suggested changes Jun 4, 2020
View reviewed changes
@lilleyse lilleyse force-pushed the remove-trailing-references branch from 27f0283 to fd1cc47 Compare June 5, 2020 00:58
@lilleyse
Copy link
Contributor Author

lilleyse commented Jun 5, 2020

@IanLilleyT updated

IanLilleyT
IanLilleyT suggested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@IanLilleyT IanLilleyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if should we be guarding against setting a negative length for both of these setters?

Looks good otherwise

@lilleyse lilleyse mentioned this pull request Jun 19, 2020
Merged
@lilleyse
Copy link
Contributor Author

@IanLilleyT added checks to the setters

@IanLilleyT IanLilleyT merged commit a92fa72 into master Jun 28, 2020
@IanLilleyT IanLilleyT deleted the remove-trailing-references branch June 28, 2020 14:05
@IanLilleyT
Copy link
Contributor

Merged. Thanks @lilleyse

@lilleyse lilleyse mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanLilleyT IanLilleyT IanLilleyT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilleyse @cesium-concierge @IanLilleyT