Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cesiumScriptRegex value #8918

Merged
merged 4 commits into from
Jun 8, 2020

Conversation

xiaobaogeit
Copy link
Contributor

fixes Issue #8902

@cesium-concierge
Copy link

Thanks for the pull request @xiaobaogeit!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @xiaobaogeit ! Can you test and/or add a unit test to confirm that CesiumSomething.js does NOT match with this regex as Matt suggested in that issue?

add CesiumSomething test
@xiaobaogeit
Copy link
Contributor Author

@OmarShehata I've added tests and the results are the same as expected

@OmarShehata
Copy link
Contributor

Thanks @xiaobaogeit .

Bumping to @mramato for final review.

@mramato
Copy link
Contributor

mramato commented Jun 8, 2020

Thanks @xiaobaogeit. The regex was a little loose than it should have been, since only ? or # should be the first valid character after Cesium.js. I pushed a small fix and test for this and will merge as soon as CI passes.

@mramato mramato merged commit f89e740 into CesiumGS:master Jun 8, 2020
@xiaobaogeit xiaobaogeit deleted the cesiumScriptRegex branch June 13, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants