Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ModelInstanceCollection test failure #8995

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

lilleyse
Copy link
Contributor

Upgraded the RiggedFigure test model to glTF 2.0 and normalized the bone weights. This fixes a local test failure in ModelInstanceCollection which had the same clipping problem as #8958 (comment).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lilleyse lilleyse requested a review from baothientran June 26, 2020 19:50
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor Author

@baothientran can you review and merge? You can use the sandcastle in #8958 (comment) and point it to the rigged figure model to visualize the difference between this branch and master.

@baothientran
Copy link
Contributor

Thanks, @lilleyse. The change fixes the issue. Here is the render in the master:

Screen Shot 2020-06-26 at 4 11 48 PM

Below is the render of the fix:

Screen Shot 2020-06-26 at 4 11 57 PM

@baothientran baothientran merged commit c404271 into master Jun 26, 2020
@lilleyse lilleyse deleted the fix-model-instance-collection-test branch June 28, 2020 00:04
@sanjeetsuhag
Copy link
Contributor

sanjeetsuhag commented Jun 30, 2020

@lilleyse @baothientran This test is failing locally. Worked fine in d0641b5, but afb7918 broke the test.

image

@baothientran
Copy link
Contributor

@sanjeetsuhag it seems like the model is rendered but the height of the model is off from the center. I'm still investigating

Screen Shot 2020-06-30 at 6 31 34 PM

@sanjeetsuhag
Copy link
Contributor

Fixed in #9006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants