Fix plane model matrix

[baothientran]

Fixes #8268

Currently the rotation is constructed manually to align the plane with the surface of the ellipsoid. This works correctly if the plane's normal is not aligned with the main axis. Instead of transforming the plane's origin and normal to the world coordinate first, we can orient the plane in the local coordinate using its original normal and origin. Then, we multiply the local transform with the world transform to convert to the world coordinate. Because the world transform already has the rotation matrix that will align the plane with the ellipsoid's surface, this should work with all of the examples as before.

@lilleyse or @hpinkos Can you please take a look at it? Please let me know if it is a right approach

[cesium-concierge]

Thanks for the pull request @baothientran!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[lilleyse]

@IanLilleyT can you review? I think you had the same idea when you wrote up #8268

[lilleyse]

@baothientran can you update CHANGES.md?

[baothientran]

CHANGES.md is updated

[IanLilleyT]

Looks good and fixes the problems in this sandcastle

Just one minor change in the comments.

[IanLilleyT]

I know this isn't code you added, but I think we can safely delete this section (lines 347 to 355). There's no way the initial up guess is aligned to both the Z and Y axes, so setting to UNIT_X will never happen.

[baothientran]

@IanLilleyT I updated to remove the unreachable condition that aligns up with X-axis.

[IanLilleyT]

Thanks @baothientran !