Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background color to doc nav bar, to help with horizontal scrolling. #9166

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Sep 21, 2020

Fixes #9162.

My local doc build is busted, so I can't test this locally except by jamming it in DevTools.

Also I set the nav bar to be a slightly darker color, to draw more attention to the main panel.

@cesium-concierge
Copy link

Thanks for the pull request @emackey!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@GatorScott
Copy link

Works well, but the horizontal scrollbar spans the entire window, not just the "content" side.

@emackey
Copy link
Contributor Author

emackey commented Sep 21, 2020

Yes, this is just a patch. Originally these things weren't supposed to horizontally scroll at all, just word-wrap more tightly. I'm not sure why some of them now have such wide minimum widths.

@OmarShehata
Copy link
Contributor

Thanks @emackey . I think this color looks nice and it's a good quick fix since it doesn't look like a bug anymore.

Before:

image

After:

image

The reader can scroll horizontally to see the obscured text.

@OmarShehata OmarShehata merged commit a8618bb into master Sep 27, 2020
@OmarShehata OmarShehata deleted the doc-nav-bar-fix branch September 27, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation is unreadable/messy on small screen
4 participants