Issue 9275 - GeoJsonDataSource process method

[thw0rted]

#9275

[cesium-concierge]

Thanks for the pull request @thw0rted!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[thw0rted]

About half of this PR is fixes for unspecified or inconsistent JSDoc -- if I need to break that out separately I can, but since I was already touching the code in question I figured it wouldn't hurt.

[cesium-concierge]

Thanks again for your contribution @thw0rted!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[hpinkos]

Thanks for the PR @thw0rted. Sorry we haven't had a chance to review this yet. I skimmed through the changes and they look fine. I'll try to make time to give this a thorough review soon.

[cesium-concierge]

Thanks again for your contribution @thw0rted!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @thw0rted!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @thw0rted!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @thw0rted!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[sanjeetsuhag]

Thanks for the contribution @thw0rted. This PR looks mostly in good shape. A few minor changes will get it over the finish line.

[thw0rted]

Oh wow, I totally forgot about this -- I'll have to dig through my notes and try to remember why I needed this 😁

I hope it's OK that I rebased with force-push rather than a merge commit, that's how I usually work locally.

Re: vscode files, I noticed that gitignore already has entries for WebStorm, would it make sense to add one for .vscode/ before closing this out?

Also also: I have no idea how out of date #8903 is but while I have your attention, maybe somebody could take a look?

[ggetz]

I have no idea how out of date #8903 is but while I have your attention, maybe somebody could take a look?

@thw0rted We're a bit bottled-necked in terms of devs with enough typescript knowledge, but we'll try to get to it soon. Thanks for your patience!

[sanjeetsuhag]

Just revisiting this PR, seems like it's close to a merge, but needs an update pass. Also, there are some unrelated changes here in the form of TypeScript changes but it would be preferred if they can be put in a dedicated PR like #8903. The gulpfile.cjs change is probably ok.

[thw0rted]

I've merged the latest from main and I think addressed all the comments above. Please let me know if anything else needs to be changed, or feel free to make the fix yourself, whatever is easiest.

[thw0rted]

FYI I went ahead and updated #8903 as well, since you're looking at this. There are a bunch of what turned out to be trivial fixes due to the when.js deprecation. I fixed @returns {Promise<void>} to @returns {when.Promise.<void>}, since the dotted-generic notation is technically correct in JSDoc, then when when was removed I replaced when.Promise with Promise, so you're left with a bunch of file changes that add a single .. If there's an easy way to remove all those changes from the PR, let me know, I'm still looking for it.

[thw0rted]

I'm confused, it looks like main has a .vscode/tasks.json and your commit just deleted that file. Was this intentional?

[sanjeetsuhag]

@thw0rted Good catch. I deleted it because in main, the file is in .vscode/tasks.json. The file in this PR was in the root directory.

But now, looking at the PR diff, it's deleting it inside .vscode/tasks.json...

[sanjeetsuhag]

Using this Sandcastle, I confirmed that this was working as expected with two GeoJSONs loading, first with load, then with process.

Thanks again @thw0rted!