Fix logic for stretching imagery to the edge of terrain. #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't correctly accounting for non-global imagery.
kring
added a commit
that referenced
this pull request
Jul 20, 2013
|
Looks like something that should have a unit test to me. But I'm not super familiar with this area of the code. |
|
Added unit tests. This is ready for another look. I looked into fixing #416 but it didn't go well and I don't think it's worth much time right now. Let's merge this and keep that one open. |
|
All good. |
pjcozzi
added a commit
that referenced
this pull request
Jul 30, 2013
Fix logic for stretching imagery to the edge of terrain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't correctly accounting for non-global imagery. This manifested as artifacts when zoomed out when using the high-res imagery I grabbed for Orange County for the SIGGRAPH demo. This might fix #416, too, but I'm not sure.