Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the basis compressed texture file extension #491

Closed
wants to merge 1 commit into from
Closed

Add support for the basis compressed texture file extension #491

wants to merge 1 commit into from

Conversation

JordyvanDortmont
Copy link

When converting a .gltf file to a .glb, the .basis compressed texture file extension is not accepted as a valid file header.

I added the file header, because soon basis will be supported in a GLTF (KhronosGroup/glTF#1612).

@lilleyse
Copy link
Contributor

lilleyse commented Aug 2, 2019

Based on the discussion in KhronosGroup/glTF#1612 it seems like the extension will require basis images to be contained in a KTX2 file (.ktx2 extension) not .basis.

Aside from that it would be good to add unit tests, one modifying gets image extension from buffer in getImageExtensionSpec.js and add two new ones in processGltfSpec.js mirroring the WebP tests. This will require adding a sample glTF and I think it's best to wait until the extension is finalized.

@JordyvanDortmont
Copy link
Author

JordyvanDortmont commented Aug 3, 2019

Thank you for the feedback. This was also confirmed here: mrdoob/three.js#17122 (comment).

I'll close the PR for now. Although there are, or were, quite some concerns around not directly including .basis files. We'll keep including them directly until the extension is finalized and if you'd like me to reopen and implement the unit tests and add a sample glTF, I'll gladly do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants