Update build-cesium task to account for prettier formatting #600
Conversation
| @@ -130,7 +130,6 @@ function amdify(source, subDependencyMapping) { | |||
| let requirePath; | |||
|
|
|||
| source = source.replace(/\r\n/g, "\n"); | |||
| source = source.replace(/\b(let|const)\b/g, "var"); | |||
There was a problem hiding this comment.
No reason to use var anymore especially now that CesiumJS has dropped support for IE11.
There was a problem hiding this comment.
does this also apply to CesiumJS source code?
There was a problem hiding this comment.
That's for us to decide. The GltfPipeline folder in CesiumJS is very self-contained so it's a good testing ground for things like this.
There was a problem hiding this comment.
Looks good to me; I confirmed this works with CesiumJS 1.84 and that all specs pass just in case. Some questions -
It uses a different version of prettier than CesiumJS so I couldn't remove it from .prettierignore.
You mentioned this in CesiumGS/cesium#9706; is there a reason why the prettier versions are different?
| @@ -130,7 +130,6 @@ function amdify(source, subDependencyMapping) { | |||
| let requirePath; | |||
|
|
|||
| source = source.replace(/\r\n/g, "\n"); | |||
| source = source.replace(/\b(let|const)\b/g, "var"); | |||
There was a problem hiding this comment.
does this also apply to CesiumJS source code?
Some of our other repos are also using the latest version of prettier. I thought it would be best to use the latest here. We're free to update the prettier version in CesiumJS as well, it just means we might need to do the whole pre-prettier and post-prettier tags against depending on the extent of changes. |
Updates the
build-cesiumtask to account for gltf-pipeline being formatted with prettier now.