Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples #63

Merged
merged 8 commits into from
Oct 25, 2021
Merged

Improve examples #63

merged 8 commits into from
Oct 25, 2021

Conversation

theory
Copy link
Contributor

@theory theory commented Oct 11, 2021

I noticed that wetzel wasn't serializing object examples, so I added that, along with tests, then realized that it also was not showing root-level examples. So I added those, too.

@emackey
Copy link
Contributor

emackey commented Oct 22, 2021

FYI @lexaknyazev, it looks like glTF is not using examples anywhere, but it would be an option after merging this PR. Not sure if that's useful to glTF spec or not, but this will likely get merged regardless.

lib/generateMarkdown.js Outdated Show resolved Hide resolved
theory and others added 2 commits October 25, 2021 16:23
Co-authored-by: Ed Mackey <elm19087@gmail.com>
@emackey
Copy link
Contributor

emackey commented Oct 25, 2021

Somehow the bullet list is still broken, at least for Markdown (but not adoc, apparently).

For example, see the bottom of: test/test-golden/v2020-12-keyword.md.

@theory
Copy link
Contributor Author

theory commented Oct 25, 2021

Yikes! I think 2cc8679 fixes it.

Copy link
Contributor

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @theory.

@emackey emackey merged commit b6bd9f6 into CesiumGS:main Oct 25, 2021
@emackey
Copy link
Contributor

emackey commented Oct 26, 2021

This is published to npm as wetzel 0.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants