Remove reference to setuptools test command #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am hoping this PR to be merged ASAP :) |
|
Linking a related issue: pypa/setuptools#4519 -- it seems like setuptools v72 has been yanked, but the test command has been deprecated for such a long time that this PR is probably still worth merging. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 1 1
Lines 60 60
=======================================
Hits 57 57
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
@lamcw thank! This change has been released as 0.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pypa/setuptools#4458
The command has been removed from latest version of setuptools (v72). Having this referenced in
setup.pywill cause installation of this package to fail with(esp. when this package is not being distributed as a wheel -- please consider distributing this as a wheel on PyPI!)