Skip to content

Commit

Permalink
fix: github action workflow (#76)
Browse files Browse the repository at this point in the history
* fix: github action workflow

* improvement: run check.yml on push and pull_request
  • Loading branch information
Juan Vásquez authored Oct 8, 2021
1 parent 0dfbe1d commit 59a018d
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 10 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Check Code

on:
pull_request_target:
branches: [main]
push:
on: [push, pull_request]

jobs:
lint:
Expand Down
12 changes: 6 additions & 6 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ Layout/EmptyLineAfterGuardClause:

Metrics/BlockLength:
Exclude:
- 'config/environments/*'
- 'spec/**/*'
- "config/environments/*"
- "spec/**/*"

Metrics/MethodLength:
Exclude:
- 'db/migrate/*'
- "db/migrate/*"

Rails/RequestReferer:
EnforcedStyle: referrer
Expand All @@ -37,11 +37,11 @@ RSpec/LetSetup:

RSpec/MultipleExpectations:
Exclude:
- 'spec/features/**/*'
- "spec/features/**/*"

RSpec/MultipleMemoizedHelpers:
Exclude:
- 'spec/features/**/*'
- "spec/features/**/*"

RSpec/NestedGroups:
Enabled: false
Expand All @@ -54,7 +54,7 @@ Style/EmptyCaseCondition:

Style/FrozenStringLiteralComment:
Exclude:
- 'app/views/**/*.json.jbuilder'
- "app/views/**/*.json.jbuilder"

Style/StringLiterals:
EnforcedStyle: double_quotes
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ group :development, :test do
gem "byebug", platforms: %i[mri mingw x64_mingw]
gem "factory_bot"
gem "factory_bot_rails"
gem "pry"
gem "rexml"
gem "rspec-rails"
gem "rubocop"
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ GEM
regexp_parser (>= 1.5, < 3.0)
xpath (~> 3.2)
childprocess (3.0.0)
coderay (1.1.3)
concurrent-ruby (1.1.8)
crass (1.0.6)
devise (4.8.0)
Expand Down Expand Up @@ -123,6 +124,9 @@ GEM
parser (3.0.1.1)
ast (~> 2.4.1)
pg (1.2.3)
pry (0.14.1)
coderay (~> 1.1)
method_source (~> 1.0)
public_suffix (4.0.6)
puma (5.3.2)
nio4r (~> 2.0)
Expand Down Expand Up @@ -271,6 +275,7 @@ DEPENDENCIES
jbuilder (~> 2.7)
listen (~> 3.3)
pg (~> 1.1)
pry
puma (~> 5.0)
pundit
rack-mini-profiler (~> 2.0)
Expand Down

0 comments on commit 59a018d

Please sign in to comment.