Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style the Login Page #46

Closed
ChaelCodes opened this issue Sep 25, 2021 · 0 comments
Closed

Style the Login Page #46

ChaelCodes opened this issue Sep 25, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ChaelCodes
Copy link
Owner

ChaelCodes commented Sep 25, 2021 •
edited
Loading

Description

The login/signup pages do not comply with our styling. Most content in ConfBuddies has a .container class on a div surrounding the content which helps to provide spacing and makes content responsive. Also, the text inputs are not styled used Bulma.

image

One thing that complicates this story is that the templates are built into Devise. We can either generate the Devise views, or be clever. That's left up to the implementer. One thing that may be helpful is our ApplicationFormBuilder. We use this to style all our inputs.
@ChaelCodes ChaelCodes added needs work this ticket is not fully groomed good first issue Good for newcomers and removed needs work this ticket is not fully groomed labels Sep 25, 2021
exegeteio added a commit to exegeteio/ConfBuddies that referenced this issue Oct 4, 2021
@exegeteio
Fix ChaelCodes#46 - Add ApplicationFormBuilder to devise templates.
1c2a231
exegeteio added a commit to exegeteio/ConfBuddies that referenced this issue Oct 4, 2021
@exegeteio
Fix ChaelCodes#46 - Add ApplicationFormBuilder to devise templates.
b4fc8b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChaelCodes