Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Share Event Attendance with everyone #51

Closed
ChaelCodes opened this issue Sep 26, 2021 · 4 comments
Closed

Don't Share Event Attendance with everyone #51

ChaelCodes opened this issue Sep 26, 2021 · 4 comments
Labels
good first issue Good for newcomers needs work this ticket is not fully groomed

Comments

@ChaelCodes
Copy link
Owner

Description

On the event_attendees/index page, we share all event attendee records. This undermines our profile privacy endeavors. Ideally, in the future, we'd show the events you are attending, and the events others are attending. For now, let's scope index down to the events that you are attending.
@ChaelCodes ChaelCodes added good first issue Good for newcomers needs work this ticket is not fully groomed labels Sep 26, 2021
@ChaelCodes ChaelCodes mentioned this issue Oct 3, 2021
Merged
@yagosansz
Copy link
Contributor

Hi @ChaelCodes, can I start working on this one?

@ChaelCodes
Copy link
Owner Author

Hi @ChaelCodes, can I start working on this one?

Sorry, there's already a PR on this one.

@ChaelCodes
Copy link
Owner Author

@yagosansz if you like this one, you may like #36.

It's a model validation.

ChaelCodes pushed a commit that referenced this issue Oct 5, 2021
@zedbydade
#51 - Don't Share Event Attendance with everyone (#58)
297105e 
* Adding search for event attendees by current_user

* Dont share event 51 (#2)

* Add sign_in method to event_attendees index route

* Associate current_user to profile user

* Adding test to validate if an event_attendees created by another user is not displayed.
@ChaelCodes
Copy link
Owner Author

Closed by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers needs work this ticket is not fully groomed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChaelCodes @yagosansz