Form error field class #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an initializer which adds a custom error class to the HTML created by ActionView::Base.
ChaelCodes
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
I love it!! I've been waiting for this change. I'm so glad we're adding it! The default is-danger is pretty subtle in the dark mode though, right?
Thanks for this! By the way, your fork is pretty out of date. We've got some new styling around login, event attendees, and default event owners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Feature or Issue
closes #107
Added an initializer to customize the CSS class added by ActiolnView to a field when in an error state. The class being added is 'is-danger'.
Checklist
User-Facing Changes
Should see a error highlight when a field is not validated. At the moment, that highlight is red per pre-existing styles.