Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Fix rubocop #75

Merged
merged 2 commits into from
Oct 8, 2021
Merged

improvement: Fix rubocop #75

merged 2 commits into from
Oct 8, 2021

Conversation

JuanVqz
Copy link
Contributor

@JuanVqz JuanVqz commented Oct 6, 2021

No description provided.

@JuanVqz
Copy link
Contributor Author

JuanVqz commented Oct 6, 2021

@ChaelCodes something SUPER weirdo it's happening here!

if you see the CI error, it's complaining about the to_not but I already changed it and we don't have any to_not in all the test suite.

spec/requests/profiles_spec.rb:141:34: C: [Correctable] RSpec/NotToNot: Prefer not_to over to_not.
          expect(profile.handle).to_not eq "ChaelChats"
                                 ^^^^^^

what do you think it could be?

Copy link
Owner

@ChaelCodes ChaelCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI is not reloading on later pushes. That'll need to be fixed, but for now, the build is salvaged!! Thank you for this PR. It means a lot.

@JuanVqz
Copy link
Contributor Author

JuanVqz commented Oct 6, 2021

Okay, let's see if it passes on the main branch 👍

@ChaelCodes ChaelCodes merged commit 0dfbe1d into ChaelCodes:main Oct 8, 2021
@ChaelCodes
Copy link
Owner

Oh my god, I can't believe I didn't merge this. I must've been feverish.

@ChaelCodes ChaelCodes added the hacktoberfest-accepted Accepted for Hacktoberfest label Oct 8, 2021
@ChaelCodes ChaelCodes added this to the Hacktoberfest 2021 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants