Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github action workflow #76

Merged
merged 5 commits into from
Oct 8, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Check Code

on:
pull_request_target:
branches: [main]
push:
on: [push, pull_request]

jobs:
lint:
Expand Down
12 changes: 6 additions & 6 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ Layout/EmptyLineAfterGuardClause:

Metrics/BlockLength:
Exclude:
- 'config/environments/*'
- 'spec/**/*'
- "config/environments/*"
- "spec/**/*"

Metrics/MethodLength:
Exclude:
- 'db/migrate/*'
- "db/migrate/*"

Rails/RequestReferer:
EnforcedStyle: referrer
Expand All @@ -37,11 +37,11 @@ RSpec/LetSetup:

RSpec/MultipleExpectations:
Exclude:
- 'spec/features/**/*'
- "spec/features/**/*"

RSpec/MultipleMemoizedHelpers:
Exclude:
- 'spec/features/**/*'
- "spec/features/**/*"

RSpec/NestedGroups:
Enabled: false
Expand All @@ -54,7 +54,7 @@ Style/EmptyCaseCondition:

Style/FrozenStringLiteralComment:
Exclude:
- 'app/views/**/*.json.jbuilder'
- "app/views/**/*.json.jbuilder"

Style/StringLiterals:
EnforcedStyle: double_quotes
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ group :development, :test do
gem "byebug", platforms: %i[mri mingw x64_mingw]
gem "factory_bot"
gem "factory_bot_rails"
gem "pry"
gem "rexml"
gem "rspec-rails"
gem "rubocop"
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ GEM
regexp_parser (>= 1.5, < 3.0)
xpath (~> 3.2)
childprocess (3.0.0)
coderay (1.1.3)
concurrent-ruby (1.1.8)
crass (1.0.6)
devise (4.8.0)
Expand Down Expand Up @@ -123,6 +124,9 @@ GEM
parser (3.0.1.1)
ast (~> 2.4.1)
pg (1.2.3)
pry (0.14.1)
coderay (~> 1.1)
method_source (~> 1.0)
public_suffix (4.0.6)
puma (5.3.2)
nio4r (~> 2.0)
Expand Down Expand Up @@ -271,6 +275,7 @@ DEPENDENCIES
jbuilder (~> 2.7)
listen (~> 3.3)
pg (~> 1.1)
pry
puma (~> 5.0)
pundit
rack-mini-profiler (~> 2.0)
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/profiles_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
it "does not update the profile" do
patch_update
profile.reload
expect(profile.handle).to_not eq "ChaelChats"
expect(profile.handle).not_to eq "ChaelChats"
end
end
end
Expand Down