-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mobile menu #98
add mobile menu #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the .gitignore made it so that we're not ignoring the right files any more, can you please check it and commit again to remove the cached files
Since it's a draft, but you requested my review, I'm not sure how much I should review the actual functionality. Sorry if this particular comment isn't helpful and you knew about it: Also I think we should have the menu drawer
|
2c3950f
to
2f4904a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, thank you so much for this. I left a couple comments, but we're super close to be golden :)
ui/src/components/Header/index.tsx
Outdated
))} | ||
</BoxStyled> | ||
)} | ||
<MultiProxySelection/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the MultiProxySelection
and the NetworkSelection
to the mobile menu?
The Kusama deployment is imminent and while the mobile view is better without the menu, I think it won't be manageable with both the network selector and the account selector in the top bar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it for sure, but as a design update are pretty close we probably could wait until the final version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the design update will really take a while to land, and start, so I think it's a low effort high reward thing to do.
BTW @asnaith, and also useful to you @Lykhoyda if you want to take a look at a PR and don't want to bother building the branch, you can go to the deployment page, where every commit is deployed. It's available from the main repo page as well: And click on the |
Closes #8