Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated transaction proposal and approval flow #33

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Updated transaction proposal and approval flow #33

merged 5 commits into from
Oct 1, 2024

Conversation

willemolding
Copy link
Contributor

Changes

  • Adds a new Proposal struct with #[wasm_bindgen] allowing the js code to hold a handle to a proposal
  • Removes transfer method in favour of a propose, create_proposed, submit flow which allows for the user to review and approve a proposal

This will also better support the AccountProvider model we are aiming for

Issues

@ec2 ec2 merged commit ce39263 into main Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign transaction proposing, authorizing and sending logic
2 participants
@willemolding @ec2