Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade node platforms #159

Closed
wants to merge 1 commit into from
Closed

chore: upgrade node platforms #159

wants to merge 1 commit into from

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Mar 7, 2024 •
edited
Loading

Upgrades to more recent nodejs versions, removing tooling issues.

@jeluard jeluard requested a review from a team as a code owner March 7, 2024 10:05
@jeluard jeluard force-pushed the jeluard/upgrade-bls-eth-wasm branch from 04eb58f to dfe7418 Compare March 7, 2024 15:32
@jeluard jeluard mentioned this pull request Mar 7, 2024
Open
6 tasks
@jeluard jeluard mentioned this pull request Mar 21, 2024
Open
@jeluard jeluard force-pushed the jeluard/upgrade-bls-eth-wasm branch from dfe7418 to 7dc6e92 Compare March 21, 2024 21:31
matthewkeil
matthewkeil approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one about testing for 18 also. Either we should require 20 or test for 18. Up to you which direction you want to go but I tend to think we should support as much as possible considering 18 is still in LTS for another year+.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
src/herumi/context.ts Outdated Show resolved Hide resolved
@jeluard
Copy link
Contributor Author

jeluard commented Mar 26, 2024

Actually webcrypto has been introduced in node 20 so this PR moves node requirement to this version.

@jeluard jeluard requested a review from matthewkeil March 26, 2024 13:15
@jeluard jeluard force-pushed the jeluard/upgrade-bls-eth-wasm branch 2 times, most recently from 02ab2ca to f63ad3e Compare April 2, 2024 15:35
@jeluard jeluard force-pushed the jeluard/upgrade-bls-eth-wasm branch from cb10792 to d9748f2 Compare April 2, 2024 20:49
@jeluard jeluard changed the title chore: upgrade bls-eth-wasm chore: upgrade node platforms Apr 2, 2024
@jeluard
Copy link
Contributor Author

jeluard commented Apr 2, 2024

@matthewkeil updated so that this PR is about updating node platforms to 18 and 20, plus some cleanup

matthewkeil
matthewkeil approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

@jeluard jeluard enabled auto-merge (squash) April 4, 2024 15:22
@jeluard jeluard disabled auto-merge April 4, 2024 15:22
@jeluard jeluard closed this Apr 4, 2024
@jeluard jeluard reopened this Apr 4, 2024
@jeluard jeluard closed this Apr 4, 2024
@jeluard jeluard deleted the jeluard/upgrade-bls-eth-wasm branch April 4, 2024 15:49
@jeluard jeluard mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

@nazarhussain nazarhussain Awaiting requested review from nazarhussain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeluard @matthewkeil