Build arm for all docker versions

ChainSafe · Feb 10, 2022 · 8d41d3d · 8d41d3d
1 parent be6deca
commit 8d41d3d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -95,6 +95,10 @@ jobs:
   build-arm:
     needs: ["build-swig"]
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node: [10, 11, 12, 13, 14, 15, 16]
     defaults:
       run:
         shell: bash
@@ -118,7 +122,7 @@ jobs:
 
       - name: Build test arm binding
         run: |
-          docker buildx build --platform linux/arm64 -t armbuild:latest --load --progress=plain .
+          docker buildx build --build-arg NODE_VERSION=${{matrix.node}} --platform linux/arm64 -t armbuild:latest --load --progress=plain .
           docker create --name armbuild armbuild:latest
           docker cp armbuild:/prebuild .
 

diff --git a/Dockerfile b/Dockerfile
@@ -1,6 +1,7 @@
 # This is used to build bindings for arm64
 
-FROM node:16
+ARG NODE_VERSION
+FROM node:${NODE_VERSION}
 
 RUN apt install -y python3 g++ make
 # && ln -sf python3 /usr/bin/python