feat!: Convert buffer usage to Uint8Array
#306
Conversation
acolytec3
changed the title
buffer usage to Uint8Arraybuffer usage to Uint8Array
|
@wemeetagain Hopefully this isn't too far beyond what you had in mind with regard to #303. Removing buffers provided an opportunity to fix 2 other pain points for Ultralight. If the |
|
@wemeetagain bump |
wemeetagain
changed the title
buffer usage to Uint8Arraybuffer usage to Uint8Array
packages/discv5/src/util/toBuffer.ts
Outdated
| } | ||
|
|
||
| export function numberToBuffer(value: number, length: number): Buffer { | ||
| export function numberToBuffer(value: number, length: number): Uint8Array { |
There was a problem hiding this comment.
Is this function still used? maybe delete it or refactor the usage of Buffer here
There was a problem hiding this comment.
Good catch. Not sure how I missed that but will do.
|
@wemeetagain should be ready for final review now. |
Fixes #303
Problems:
enrpackages referencesglobalThis.Bufferin the base64 conversion utilities and this causes segmentation faults in theUltralighthive testsBufferwas only used for bytes (instead ofUint8Array) because of the requirements ofbcryptowhich only acceptedBufferas input.bigint-bufferpackage causes CI failures in Ultralight with arbitrarynapi-ok === falseerrors that are indecipherableSolution:
Buffertypes and utilities and replace with equivalent Uint8ArraystoHex/fromHexusage tohexToBytes/bytesToHexfromethereum-cryptographyutf8conversion toethereum-cryptographyutf8ToBytes/bytesToUtf8utilitiesglobalThis.bufferscure/base(author same as@noble/hashes)bigint-bufferand replace with internalbigIntToBytes/bytesToBigIntconversion utilities