feat: create separate enr package #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
force-pushed
the
cayman/monorepo
branch
from
d207fa8 to
2b81699
Compare
dapplion
approved these changes
Nov 20, 2023
This was referenced Nov 29, 2023
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns this repository into a monorepo with 2 packages:
@chainsafe/discv5and@chainsafe/enrThe rationale is this:
Its useful to have enr creating / parsing utilities independent of discv5. This is the first step in making the enr library more lightweight and suitable as a general purpose enr library. Further steps will be taken later to remove heavy dependencies.