Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enr implementation #35

Merged
merged 10 commits into from
Nov 23, 2019
Merged

Add enr implementation #35

merged 10 commits into from
Nov 23, 2019

Conversation

wemeetagain
Copy link
Member

Basic ENR implementation
follows EIP778
uses included test vector

@wemeetagain wemeetagain requested review from GregTheGreek and a team November 14, 2019 06:59
mpetrunic
mpetrunic requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wan't browser friendly lib, you should probably use buffer dep and import {Buffer} from "buffer" everywhere

GregTheGreek
GregTheGreek reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you address Marin's comments

mpetrunic
mpetrunic reviewed Nov 20, 2019
View reviewed changes
ec2
ec2 reviewed Nov 20, 2019
View reviewed changes
ec2
ec2 reviewed Nov 20, 2019
View reviewed changes
ec2
ec2 reviewed Nov 20, 2019
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mpetrunic
Copy link
Member

@wemeetagain CI is failing, some type error. I'll try to retrigger CLA

@mpetrunic mpetrunic merged commit 50e70f0 into master Nov 23, 2019
@mpetrunic mpetrunic deleted the cayman/enr branch November 23, 2019 16:40
acolytec3 added a commit to acolytec3/discv5 that referenced this pull request Dec 22, 2021
@acolytec3
UI Updates (ChainSafe#35)
f9901c6 
* Update Node List when new ENR added
* Add more UI clarity and radius updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregTheGreek GregTheGreek GregTheGreek left review comments

@ec2 ec2 ec2 approved these changes

@mpetrunic mpetrunic mpetrunic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wemeetagain @CLAassistant @mpetrunic @ec2 @GregTheGreek