Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

fix: gaslimit #254

Merged
merged 3 commits into from
Mar 27, 2023
Merged

fix: gaslimit #254

merged 3 commits into from
Mar 27, 2023

Conversation

hugomrdias
Copy link
Collaborator

Fixed gasLimit estimation in estimateMessageGas and signMessage by using gasEstimateMessageGas method directly instead of calling gasEstimateGasLimitwhich failed saying it didnt exist.

@BeroBurny
Copy link
Contributor

The build is failing because of manifest mismatch, for easy fix you can

  • from the root folder run yarn run manifest
  • inside the package execute this mm-snap manifest in nterminal

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1c11454
Status: ✅  Deploy successful!
Preview URL: https://592339ae.filsnap.pages.dev
Branch Preview URL: https://fix-gas-limit.filsnap.pages.dev

View logs

@hugomrdias
Copy link
Collaborator Author

ty @BeroBurny, the cmd is actually yarn build but i got it working and fixed the test should be ready for review.

Copy link
Collaborator

@meandavejustice meandavejustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BeroBurny BeroBurny merged commit 067fce8 into master Mar 27, 2023
@BeroBurny BeroBurny deleted the fix/gas-limit branch March 27, 2023 07:16
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants