This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
MetaMask Changes #82
Merged
MetaMask Changes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mpetrunic
reviewed
Oct 27, 2021
| @@ -16,14 +16,21 @@ | |||
| "type-check:watch": "npm run type-check -- --watch", | |||
| "build": "yarn run build:tsc && yarn run build:snap", | |||
| "build:tsc": "tsc -p tsconfig.build.json --pretty --outDir build", | |||
| "build:snap": "nf-snap build --stripComments --debug --verbose", | |||
| "build:snap": "yarn build:snap:bundle && yarn build:snap:postprocess && yarn build:snap:eval", | |||
| "build:snap:bundle": "nf-snap build --stripComments --debug --verbose --eval false", | |||
There was a problem hiding this comment.
@rekmarks is my pr with comment stripping released in snaps-cli? Maybe we can switch to official version instead of our fork
There was a problem hiding this comment.
Yup! The option is exactly the same as you have here. snaps-cli is now released under this package: https://www.npmjs.com/package/@metamask/snaps-cli
There was a problem hiding this comment.
Yeah than we dont need our fork anymore 😄
|
I'm not sure why the build is failing as of 7d3c5f8, it passes for me locally. |
MakMuftic
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make
filsnapcompatible with the latest version of MetaMask Snaps.Note: This PR updates the TypeScript and
react-scriptversion of the monorepo. This was necessary for compatibility reasons with@metamask/dependencies.